Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct traceQL metrics documentation #4252

Merged

Conversation

javiermolinar
Copy link
Contributor

What this PR does:
It corrects some typos in the documentation relative to TraceQL Metrics

Checklist

  • Documentation added

Copy link
Contributor

This PR must be merged before a backport PR will be created.

1 similar comment
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@@ -60,7 +60,7 @@ Refer to [Solve problems using metrics queries](./solve-problems-metrics-queries

### Functions

TraceQL metrics queries currently include the following functions for aggregating over groups of spans: `rate`, `count_over_time`, `quantile_over_time`, `histogram_over_time`, and `compare`.
TraceQL metrics queries currently include the following functions for aggregating over groups of spans: `rate`, `count_over_time`,`min_over_tim`,`max_over_time`, `quantile_over_time`, `histogram_over_time`, and `compare`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds missing spaces between min and max over time.

Suggested change
TraceQL metrics queries currently include the following functions for aggregating over groups of spans: `rate`, `count_over_time`,`min_over_tim`,`max_over_time`, `quantile_over_time`, `histogram_over_time`, and `compare`.
TraceQL metrics queries currently include the following functions for aggregating over groups of spans: `rate`, `count_over_time`, `min_over_tim`, `max_over_time`, `quantile_over_time`, `histogram_over_time`, and `compare`.

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs! I've added two suggestions or missing spaces between min and max time.

@knylander-grafana knylander-grafana merged commit fc05aec into grafana:main Nov 4, 2024
17 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 4, 2024
Co-authored-by: Kim Nylander <[email protected]>
(cherry picked from commit fc05aec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-v2.6 type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants